[webkit-reviews] review denied: [Bug 111334] Web Inspector: Plumbing CSS warnings : [Attachment 191730] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 6 05:42:46 PST 2013


Pavel Feldman <pfeldman at chromium.org> has denied Sergey Ryazanov
<serya at chromium.org>'s request for review:
Bug 111334: Web Inspector: Plumbing CSS warnings
https://bugs.webkit.org/show_bug.cgi?id=111334

Attachment 191730: Patch
https://bugs.webkit.org/attachment.cgi?id=191730&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191730&action=review


> Source/WebCore/dom/Document.cpp:4780
> +void Document::addConsoleMessage(MessageSource source, MessageLevel level,
const String& message, const KURL& sourceURL, int lineNumber)

As I mentioned, I don't think piping console messages through DOMWindow is the
way to go.


More information about the webkit-reviews mailing list