[webkit-reviews] review granted: [Bug 111562] [Qt] Illegal narrowing in tst_qwebhistory : [Attachment 191722] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 6 05:30:09 PST 2013


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 111562: [Qt] Illegal narrowing in tst_qwebhistory
https://bugs.webkit.org/show_bug.cgi?id=111562

Attachment 191722: Patch
https://bugs.webkit.org/attachment.cgi?id=191722&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191722&action=review


Oops

> Source/WebKit/qt/tests/qwebhistory/tst_qwebhistory.cpp:517
> +    QByteArray version1((const char*)version1Dump, sizeof(version1Dump));

Nit: static_cast


More information about the webkit-reviews mailing list