[webkit-reviews] review granted: [Bug 111403] File.lastModifiedDate() should return the current date/time if the file date/time is not available : [Attachment 191696] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 6 04:25:35 PST 2013
Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 111403: File.lastModifiedDate() should return the current date/time if the
file date/time is not available
https://bugs.webkit.org/show_bug.cgi?id=111403
Attachment 191696: Patch
https://bugs.webkit.org/attachment.cgi?id=191696&action=review
------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191696&action=review
> Source/WebCore/fileapi/File.cpp:157
> + return m_snapshotModificationTime * WTF::msPerSecond;
nit: We usually omit "WTF::" prefix.
> Source/WebCore/fileapi/File.cpp:162
> + return modificationTime * WTF::msPerSecond;
Ditto.
> Source/WebCore/fileapi/File.cpp:164
> + return currentTime() * WTF::msPerSecond;
Ditto.
More information about the webkit-reviews
mailing list