[webkit-reviews] review denied: [Bug 110614] [GTK][WK2] Add document-loaded signal to WebKitWebPage : [Attachment 190888] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 110614: [GTK][WK2] Add document-loaded signal to WebKitWebPage
https://bugs.webkit.org/show_bug.cgi?id=110614

Attachment 190888: Patch
https://bugs.webkit.org/attachment.cgi?id=190888&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190888&action=review


Found a problem in the unit tests

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp:70
> +    g_main_loop_run(test->m_mainLoop);

You should unsubscribe the signal here, or it will affect other tests finishing
the main loop when document loaded is emitted. See
g_dbus_connection_signal_unsubscribe().