[webkit-reviews] review granted: [Bug 110197] [EFL][WK2] Convert from device view size to UI view size only in EwkView. : [Attachment 191623] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 6 00:34:28 PST 2013


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 110197: [EFL][WK2] Convert from device view size to UI view size only in
EwkView.
https://bugs.webkit.org/show_bug.cgi?id=110197

Attachment 191623: Patch
https://bugs.webkit.org/attachment.cgi?id=191623&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191623&action=review


r=me with the change (signed off by Benjamin)

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:466
> -void EwkView::setSize(const IntSize& size)
> +void EwkView::setSize(const IntSize& deviceSize)

This should be renamed to setDeviceSize then as the getter is called
deviceSize()


More information about the webkit-reviews mailing list