[webkit-reviews] review denied: [Bug 110375] Add client callbacks to notify of changes of associated from controls : [Attachment 191632] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 23:52:23 PST 2013


Hajime Morrita <morrita at google.com> has denied Dane Walllinga
<dgwallinga at chromium.org>'s request for review:
Bug 110375: Add client callbacks to notify of changes of associated from
controls
https://bugs.webkit.org/show_bug.cgi?id=110375

Attachment 191632: Patch
https://bugs.webkit.org/attachment.cgi?id=191632&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191632&action=review


r- for the build breakages.

> Source/WebCore/page/ChromeClient.h:387
> +    virtual bool shouldNotifyOnFormChanges() = { return false; };

Wrong "="?


More information about the webkit-reviews mailing list