[webkit-reviews] review denied: [Bug 111483] Modify log method in DOMActivityLogger : [Attachment 191625] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 22:50:53 PST 2013


Adam Barth <abarth at webkit.org> has denied Ankur Taly <ataly at google.com>'s
request for review:
Bug 111483: Modify log method in DOMActivityLogger
https://bugs.webkit.org/show_bug.cgi?id=111483

Attachment 191625: Patch
https://bugs.webkit.org/attachment.cgi?id=191625&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191625&action=review


> Source/WebCore/ChangeLog:9
> +	   https://bugs.webkit.org/show_bug.cgi?id=111483
> +
> +	   Reviewed by NOBODY (OOPS!).
> +

Please explain why you're making this change in the ChangeLog.

> Source/WebCore/ChangeLog:10
> +	   No new tests (OOPS!).

This line will prevent your patch from being landed.  You should explain that
there are no tests because there is no behavior change.


More information about the webkit-reviews mailing list