[webkit-reviews] review denied: [Bug 105518] "PlaybackTime" parameter is not present in AudioProcessingEvent Interface as per W3C spec : [Attachment 191618] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Praveen Jadhav
<praveen.j at samsung.com>'s request for review:
Bug 105518: "PlaybackTime" parameter is not present in AudioProcessingEvent
Interface as per W3C spec
https://bugs.webkit.org/show_bug.cgi?id=105518

Attachment 191618: Patch
https://bugs.webkit.org/attachment.cgi?id=191618&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191618&action=review


> Maybe "context.oncomplete = finishJSTest"(not sure). But the current approach
is working for me. Only chromium-ews fails.

What is the failure?

> Source/WebCore/ChangeLog:9
> +	   Attribute "playbackTime" in AudioProcessingEvent implemented to pass
current audio time
> +	   of the context.

Please add the spec link here.

> Source/WebCore/Modules/webaudio/AudioProcessingEvent.idl:29
> +    readonly attribute double playbackTime;

The spec specifies 'float' not 'double'. You need to align the implementation
with the spec or propose to change the spec:)

> Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp:252
> -	   dispatchEvent(AudioProcessingEvent::create(inputBuffer,
outputBuffer));
> +	   // FIXME: Delay node is not considered while calculating
playbackTime. Latency should be retested with more scenarios.
> +	   dispatchEvent(AudioProcessingEvent::create(inputBuffer,
outputBuffer, context()->currentTime() + outputBuffer->duration()));

Why is this change needed?