[webkit-reviews] review denied: [Bug 111470] Implement CSS display-box property : [Attachment 191543] WIP

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 19:37:14 PST 2013


Ojan Vafai <ojan at chromium.org> has denied Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 111470: Implement CSS display-box property
https://bugs.webkit.org/show_bug.cgi?id=111470

Attachment 191543: WIP
https://bugs.webkit.org/attachment.cgi?id=191543&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
I think we need to wait for the www-style discussion to be resolved before we
move forward here.

Some thoughts on this patch as is:
-I don't like changing "effective" to "actual". I feel like effective is more
clear (i.e. actual as opposed to what? fake?).
-Needs tests. Some cases that need to be tested: display:none;display-box:none,
display:flex;display-box:none, display:none;display-box:normal,
display:flex;display-box:normal


More information about the webkit-reviews mailing list