[webkit-reviews] review granted: [Bug 111504] build a DumpRenderTree.pak even on windows : [Attachment 191620] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 111504: build a DumpRenderTree.pak even on windows
https://bugs.webkit.org/show_bug.cgi?id=111504

Attachment 191620: Patch
https://bugs.webkit.org/attachment.cgi?id=191620&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191620&action=review


>> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:-345
>> -			}],
> 
> I don't know why we were previously building the .pak file in
<(INTERMEDIATE_DIR) and then copying it into <(PRODUCT_DIR). Is there a reason
not to just build it into <(PRODUCT_DIR) by default?

Not sure, but it seems fine to write the final result to <(PRODUCT_DIR).