[webkit-reviews] review granted: [Bug 107601] Default mouse cursor behavior should be auto-hide for full screen video with custom controls : [Attachment 191373] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 16:38:44 PST 2013


Beth Dakin <bdakin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 107601: Default mouse cursor behavior should be auto-hide for full screen
video with custom controls
https://bugs.webkit.org/show_bug.cgi?id=107601

Attachment 191373: Patch
https://bugs.webkit.org/attachment.cgi?id=191373&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191373&action=review


> Source/WebCore/page/EventHandler.cpp:75
> +#include "RenderTheme.h"

Do you need this?

> Source/WebCore/rendering/style/RenderStyleConstants.h:422
> +enum CursorVisibility {

I agree with StyleBot here!! So, CursorVisibilityAuto and
CursorVisibilityAutoHide.


More information about the webkit-reviews mailing list