[webkit-reviews] review denied: [Bug 102775] Loader: Store WeakRef CachedResourceHandle in CachedResourceLoader : [Attachment 191417] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 15:22:33 PST 2013


Adam Barth <abarth at webkit.org> has denied pdeng6 <pan.deng at intel.com>'s request
for review:
Bug 102775: Loader: Store WeakRef CachedResourceHandle in CachedResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=102775

Attachment 191417: Patch
https://bugs.webkit.org/attachment.cgi?id=191417&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I don't think we should use WeakPtr in the loader yet.	The loader's lifetime
management is already very complex and error-prone.  We don't have enough
experience with WeakPtr as a project yet to make good decisions about how to
use WeakPtr in such complex environments.


More information about the webkit-reviews mailing list