[webkit-reviews] review granted: [Bug 111467] Each web process truncates the disk cache to zero on launch : [Attachment 191537] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 14:01:54 PST 2013


Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 111467: Each web process truncates the disk cache to zero on launch
https://bugs.webkit.org/show_bug.cgi?id=111467

Attachment 191537: Patch
https://bugs.webkit.org/attachment.cgi?id=191537&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191537&action=review


> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:165
> +	       NSUInteger cacheMemoryCapacity =
parameters.nsURLCacheMemoryCapacity;
> +	       NSUInteger cacheDiskCapacity =
parameters.nsURLCacheDiskCapacity;

Strange to put two arguments into local variables here, but not the third. All
three or none?

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:168
> +		   RetainPtr<NSURLCache> parentProcessURLCache(AdoptNS,
[[NSURLCache alloc] initWithMemoryCapacity:cacheMemoryCapacity
diskCapacity:cacheDiskCapacity diskPath:parameters.diskCacheDirectory]);
> +		   [NSURLCache setSharedURLCache:parentProcessURLCache.get()];

Wrong indentation here.


More information about the webkit-reviews mailing list