[webkit-reviews] review denied: [Bug 107848] [CSS Filters] Using negative drop-shadow radius values has slow performance : [Attachment 191548] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Michelangelo De Simone
<michelangelo at webkit.org>'s request for review:
Bug 107848: [CSS Filters] Using negative drop-shadow radius values has slow
performance
https://bugs.webkit.org/show_bug.cgi?id=107848

Attachment 191548: Patch
https://bugs.webkit.org/attachment.cgi?id=191548&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191548&action=review


Please look onto the style issue. Looks like you need to set the mime type
manually? There is just one little change request. Other than that the patch
looks great!

> LayoutTests/ChangeLog:16
> +	   * fast/box-shadow/box-shadow-negative-radius-expected.html: Added.
> +	   * fast/box-shadow/box-shadow-negative-radius.html: Added.

box shadow seems really to miss parsing tests. That is really really bad. Would
it be possible that you create a box-shadow-parsing-invalid.html similar to
other tests where you test just your part. Create a new bug report to add
parser tests for box-shadow and add a FIXME into this new created file. I
really appreciate if you do that. Thanks.