[webkit-reviews] review denied: [Bug 110487] Ctrl+Shift+Right in Windows should select the spacing after the word : [Attachment 190658] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 110487: Ctrl+Shift+Right in Windows should select the spacing after the
word
https://bugs.webkit.org/show_bug.cgi?id=110487

Attachment 190658: Patch
https://bugs.webkit.org/attachment.cgi?id=190658&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190658&action=review


I think that Ryosuke's request is not to implement Windows behavior using
NSString APIs, but to make sure that editing behavior is not determined at
compile time.

We want to test all platforms behavior in regression tests, using a
window.internals switch to choose editing behavior in each test. This way,
running tests locally would be a better indication that a patch is correct.

Since the patch still does not have tests, it's automatically r-.

> Source/WTF/wtf/unicode/icu/UnicodeIcu.h:179
> +inline bool isSpace(UChar32 c)
> +{
> +    return !!u_isWhitespace(c);
> +}

This is not a good name for this function (isWhitespace is not so great either,
but it's OK in ICU context).

There are multiple definitions of whitespace used in the Web platform. They may
or may not include Unicode spaces, form feeds etc.