[webkit-reviews] review granted: [Bug 107963] Add FrameLoaderClient::didAccessInitialDocument : [Attachment 191372] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Charles Reis <creis at chromium.org>'s
request for review:
Bug 107963: Add FrameLoaderClient::didAccessInitialDocument
https://bugs.webkit.org/show_bug.cgi?id=107963

Attachment 191372: Patch
https://bugs.webkit.org/attachment.cgi?id=191372&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191372&action=review


> Source/WebCore/loader/FrameLoader.cpp:1601
> +{

I would have added an ASSERT here that m_didAccessInitialDocument was set, but
you don't need to re-spin your patch for that.

> Source/WebKit/chromium/tests/WebFrameTest.cpp:2433
> +    TestAccessInitialDocumentWebFrameClient() :
m_didAccessInitialDocument(false)

Technically the : and the characters after that go on a new line.