[webkit-reviews] review granted: [Bug 111399] Inline min/maxInstrinsicLogicalWidth functions : [Attachment 191530] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 111399: Inline min/maxInstrinsicLogicalWidth functions
https://bugs.webkit.org/show_bug.cgi?id=111399

Attachment 191530: Patch
https://bugs.webkit.org/attachment.cgi?id=191530&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191530&action=review


> Source/WebCore/rendering/RenderBox.cpp:2116
> +	   RenderView* renderView = view();
> +	   LayoutUnit marginStart =
minimumValueForLength(style()->marginStart(), availableLogicalWidth,
renderView);
> +	   LayoutUnit marginEnd = minimumValueForLength(style()->marginEnd(),
availableLogicalWidth, renderView);

Maybe you should pass in 2 additional args to fillAvailableMeasure that will
return marginStart and marginEnd by reference?	Maybe this should just be 2
separate methods.