[webkit-reviews] review denied: [Bug 111422] Fix selection handling in a couple of editing tests : [Attachment 191476] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 5 10:24:12 PST 2013
Ryosuke Niwa <rniwa at webkit.org> has denied Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 111422: Fix selection handling in a couple of editing tests
https://bugs.webkit.org/show_bug.cgi?id=111422
Attachment 191476: Patch
https://bugs.webkit.org/attachment.cgi?id=191476&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191476&action=review
>> LayoutTests/ChangeLog:11
>> + paragraph instead.
>
> Do we have a way to force specific platform behavior in the test? Many
editing behaviors are overridable via internals.
>
> It is better to have a way to test all platform behaviors in regression
tests, not to avoid things that are platform dependent.
I agree with Alexey. r-.
More information about the webkit-reviews
mailing list