[webkit-reviews] review denied: [Bug 104268] [chromium] expose UserGestureIndicator::Token via WebKit API so PPAPI plugins can correctly consume it : [Attachment 191442] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied
jochen at chromium.org's request for review:
Bug 104268: [chromium] expose UserGestureIndicator::Token via WebKit API so
PPAPI plugins can correctly consume it
https://bugs.webkit.org/show_bug.cgi?id=104268

Attachment 191442: Patch
https://bugs.webkit.org/attachment.cgi?id=191442&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191442&action=review


> Source/WebKit/chromium/public/WebFrame.h:416
> +    virtual WebUserGestureToken* currentUserGestureToken() const = 0;

methods that return objects which need to be destroyed by the caller are
usually
prefixed with "create".  That might make this method sound odd.

> Source/WebKit/chromium/public/WebUserGestureToken.h:59
> +    WebPrivatePtr<WebCore::UserGestureToken> m_token;

Since you are using WebPrivatePtr here, it seems like you should arrange for
embedders of WebKit to pass around WebUserGestureToken by value.  Treat it like

a smart pointer (like RefPtr) just as we do with WebNode and many other similar

wrapper types.	This way the "currentUserGestureToken" method can just return
a WebUserGestureToken by value.