[webkit-reviews] review granted: [Bug 111442] Web Inspector: Flame Chart. Provide node context info in a popover when mouse hovers over a flame chart item : [Attachment 191499] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 111442: Web Inspector: Flame Chart. Provide node context info in a popover
when mouse hovers over a flame chart item
https://bugs.webkit.org/show_bug.cgi?id=111442

Attachment 191499: Patch
https://bugs.webkit.org/attachment.cgi?id=191499&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191499&action=review


Please attach a screenshot.

> Source/WebCore/ChangeLog:8
> +	   FlameChart creates a fake anchor element and moves it to the right
position.

Can you rephrase this or add more context?

> Source/WebCore/inspector/front-end/FlameChart.js:93
> +	   if (typeof node === 'undefined' && !this._highlightedNode)

Please use " instead of '

> Source/WebCore/inspector/front-end/FlameChart.js:120
> +		   style.height = this._yScaleFactor + "px";

Consider renaming _yScaleFactor to _barHeight