[webkit-reviews] review canceled: [Bug 109455] [WK2] Allow using the value of WebContext::platformDefaultIconDatabasePath from the C API : [Attachment 187601] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 07:17:40 PST 2013


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has canceled Jocelyn Turcotte
<jocelyn.turcotte at digia.com>'s request for review:
Bug 109455: [WK2] Allow using the value of
WebContext::platformDefaultIconDatabasePath from the C API
https://bugs.webkit.org/show_bug.cgi?id=109455

Attachment 187601: Patch
https://bugs.webkit.org/attachment.cgi?id=187601&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
(In reply to comment #7)
> WKContextSetIconDatabasePath is the call in the current C API that opens the
icon database.
> 
> You can call it with the default path to open the database at the default
path.
> 
> The notion of a "default path" was a mistake.  Clients should always have to
explicitly provide a path.

Alright, that makes sense.
I've gone that way with the patch for bug 111435, thanks for the input.


More information about the webkit-reviews mailing list