[webkit-reviews] review granted: [Bug 111431] Web Inspector: move PopoverContentHelper from TimelinePresentationModel.js to Popover.js : [Attachment 191483] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 111431: Web Inspector: move PopoverContentHelper from
TimelinePresentationModel.js to Popover.js
https://bugs.webkit.org/show_bug.cgi?id=111431

Attachment 191483: Patch
https://bugs.webkit.org/attachment.cgi?id=191483&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191483&action=review


> Source/WebCore/inspector/front-end/Popover.js:374
> +WebInspector.PopupContentHelper = function(title)

Consider renaming to PopoverTableHelper ?

> Source/WebCore/inspector/front-end/Popover.js:430
> +    appendStackTrace: function(title, stackTrace, callFrameLinkifier)

Now Popover.js depends on the stack trace, can we avoid this?