[webkit-reviews] review denied: [Bug 111337] Web Inspector: Add a renderer process memory size test. : [Attachment 191256] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 04:04:04 PST 2013


Yury Semikhatsky <yurys at chromium.org> has denied Alexei Filippov
<alph at chromium.org>'s request for review:
Bug 111337: Web Inspector: Add a renderer process memory size test.
https://bugs.webkit.org/show_bug.cgi?id=111337

Attachment 191256: Patch
https://bugs.webkit.org/attachment.cgi?id=191256&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191256&action=review


> Source/WebKit/chromium/src/js/Tests.js:333
> +	   checkFuzzyValue(memoryBlock.size, 8000 * KB, 0.5);

We should allow for a broader range otherwise it is bound to be flaky. I think
it would be enough to check that it is >1Mb and < 1.5Gb or something.


More information about the webkit-reviews mailing list