[webkit-reviews] review denied: [Bug 111173] Web Inspector: Move sidebar-specific styles to a separate file : [Attachment 191244] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vladislav Kaznacheev
<kaznacheev at chromium.org>'s request for review:
Bug 111173: Web Inspector: Move sidebar-specific styles to a separate file
https://bugs.webkit.org/show_bug.cgi?id=111173

Attachment 191244: Patch
https://bugs.webkit.org/attachment.cgi?id=191244&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191244&action=review


> Source/WebCore/inspector/front-end/elementsPanel.css:534
> +.sidebar-pane-toolbar > select:hover {

I would imagine that this file only gets styles with ".elements-" prefix
otherwise, you are at risk of breaking stuff on other panels (styles are
unloaded when you switch off the panel).

> Source/WebCore/inspector/front-end/scriptsPanel.css:312
> +.sidebar-pane > .body .breakpoint-condition {

Like these ones are ok - they all mention breakpoint...

> Source/WebCore/inspector/front-end/scriptsPanel.css:328
> +ol.breakpoint-list {

And what about DOM Breakpoints? They might rely upon this style. I might be
that breakpoints list view might need to have its own CSS.

> Source/WebCore/inspector/front-end/sidebarPane.css:73
> +.pane-title {

Should we rename this to .sidebar-pane-title?