[webkit-reviews] review denied: [Bug 111334] Web Inspector: Plumbing CSS warnings : [Attachment 191253] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Sergey Ryazanov
<serya at chromium.org>'s request for review:
Bug 111334: Web Inspector: Plumbing CSS warnings
https://bugs.webkit.org/show_bug.cgi?id=111334

Attachment 191253: Patch
https://bugs.webkit.org/attachment.cgi?id=191253&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191253&action=review


> Source/WebCore/css/CSSParser.cpp:61
> +#include "DOMWindow.h"

I don't think CSSParser should depend on DOMWindow.

> Source/WebCore/css/CSSParser.cpp:11126
> +	       builder.appendLiteral("\\n");

I still think CSSParser should not bother with formatting. It should pass as
much info as possible into console.

> Source/WebCore/css/CSSParser.cpp:11717
> +CSSParser::Location CSSParser::currentLocation()

This seems to be unused.

> Source/WebCore/css/CSSParser.h:382
> +    Console* m_console;

You should not store console pointer in parser.