[webkit-reviews] review granted: [Bug 111411] [Custom Elements][V8] Custom Element doesn't need its own WrapperTypeInfo : [Attachment 191450] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 5 03:16:27 PST 2013
Kentaro Hara <haraken at chromium.org> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 111411: [Custom Elements][V8] Custom Element doesn't need its own
WrapperTypeInfo
https://bugs.webkit.org/show_bug.cgi?id=111411
Attachment 191450: Patch
https://bugs.webkit.org/attachment.cgi?id=191450&action=review
------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191450&action=review
LGTM.
> Source/WebCore/bindings/v8/V8HTMLCustomElement.cpp:62
> + v8::Handle<v8::Value> wrapperValue =
toV8(toHTMLUnknownElement(impl.get()), creationContext, isolate);
Hmm? You said a compiler wants WebCore::, but did you remove WebCore:: ?
More information about the webkit-reviews
mailing list