[webkit-reviews] review granted: [Bug 87054] ContainerNode::setActive should not sleep for 100ms on platforms that do not implement synchronous repaint(true) semantics : [Attachment 191391] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 21:02:31 PST 2013


Darin Adler <darin at apple.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 87054: ContainerNode::setActive should not sleep for 100ms on platforms
that do not implement synchronous repaint(true) semantics
https://bugs.webkit.org/show_bug.cgi?id=87054

Attachment 191391: Patch
https://bugs.webkit.org/attachment.cgi?id=191391&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191391&action=review


Looks fine.

> Source/WebCore/ChangeLog:16
> +	   (ChromeClient):

Should drop this bogus line. Wish the change log script would do a better job.

> Source/WebKit/mac/ChangeLog:11
> +	   (WebChromeClient):

Should drop this bogus line. Wish the change log script would do a better job.

> Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm:506
> +
> +

Extra blank line here.


More information about the webkit-reviews mailing list