[webkit-reviews] review granted: [Bug 110932] [chromium] Implement TRACE_EVENT macros for sampling profiling : [Attachment 190532] fixed builds

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 110932: [chromium] Implement TRACE_EVENT macros for sampling profiling
https://bugs.webkit.org/show_bug.cgi?id=110932

Attachment 190532: fixed builds
https://bugs.webkit.org/attachment.cgi?id=190532&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190532&action=review


r=me, assuming you're confident in the answer to my question below.

> Source/WebCore/platform/chromium/TraceEvent.h:559
> +	   *WebCore::traceSamplingState##threadBucket =
reinterpret_cast<TraceEventAPIAtomicWord>("WebKit\0" name); \

Is this operation really atomic?  You're using names like "AtomicWord" in the
names of the types, but I don't know enough about the subtle threading issues
to know if what you're doing here is sufficient.