[webkit-reviews] review denied: [Bug 111324] [WebGL] Mark Extension3D functions as const. : [Attachment 191345] patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Kalyan
<kalyan.kondapally at intel.com>'s request for review:
Bug 111324: [WebGL] Mark Extension3D functions as const.
https://bugs.webkit.org/show_bug.cgi?id=111324

Attachment 191345: patch
https://bugs.webkit.org/attachment.cgi?id=191345&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191345&action=review


May I ask what the goal of this patch is? While conceptually some of these
methods are const, as you have already found, they may do some mutations
internally which are invisible to callers. Neither the ChangeLog nor the bug
explains the motivation for the patch.

> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp:244
> +	      
const_cast<Extensions3DOpenGLES*>(this)->resolveVAOExtBindings();

Rather than casting away const, these members should be made mutable -- that's
what the keyword is for.