[webkit-reviews] review denied: [Bug 111319] Replace spin buttons with clear button for input types date/week/month/datetime-local : [Attachment 191307] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura (ooo until Mar 15) <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 111319: Replace spin buttons with clear button for input types
date/week/month/datetime-local
https://bugs.webkit.org/show_bug.cgi?id=111319

Attachment 191307: Patch
https://bugs.webkit.org/attachment.cgi?id=191307&action=review

------- Additional Comments from Kent Tamura (ooo until Mar 15)
<tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191307&action=review


> Source/WebCore/ChangeLog:8
> +	   We are going to replace the spin buttons in input types
date/week/month/datetime-local with a clear value button.

I don't think the replacement is reasonable. Why don't you just add the clear
button?
The input[type=time] exception is bad for consistency, and we want the clear
button for input[type=time] too.

> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp:499
> +    if (element()->isRequired() ||
m_dateTimeEditElement->valueAsDateTimeFieldsState().isEmpty())

m_dateTimeEditElement->valueAsDateTimeFieldsState().isEmpty() is equivalent to
!m_dateTimeEditElement->anyEditableFieldsHaveValues()

> Source/WebCore/html/shadow/ClearButtonElement.h:33
> +class ClearButtonElement : public HTMLDivElement {

We had better re-use SearchFieldCancelButtonElement.