[webkit-reviews] review granted: [Bug 111376] Make AsyncFileReader work without ScriptExecutionContext : [Attachment 191346] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 4 16:45:17 PST 2013
Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 111376: Make AsyncFileReader work without ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=111376
Attachment 191346: proposed patch
https://bugs.webkit.org/attachment.cgi?id=191346&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191346&action=review
Instead of adding MainThreadTask, I think you should use something more like
WTF::Function from Functional.h - I don’t think that blocks landing this
though.
> Source/WebCore/fileapi/AsyncFileStream.cpp:54
> + return thread;
return thread.release(); (Not that it matters :)
More information about the webkit-reviews
mailing list