[webkit-reviews] review denied: [Bug 107963] Add FrameLoaderClient::didAccessInitialDocument : [Attachment 191299] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 16:38:09 PST 2013


Adam Barth <abarth at webkit.org> has denied Charles Reis <creis at chromium.org>'s
request for review:
Bug 107963: Add FrameLoaderClient::didAccessInitialDocument
https://bugs.webkit.org/show_bug.cgi?id=107963

Attachment 191299: Patch
https://bugs.webkit.org/attachment.cgi?id=191299&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191299&action=review


One minor issue below.

> Source/WebCore/loader/FrameLoader.cpp:1594
> +	   m_client->didAccessInitialDocument();

It's a bit scary to make this call in the middle of the v8 security check.  I
don't think we expect to be re-entered in that state.  Perhaps we should use a
timer to make the call asynchronously.


More information about the webkit-reviews mailing list