[webkit-reviews] review denied: [Bug 108370] Some spellcheck tests require asynchronous spellcheck : [Attachment 191329] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Rouslan Solomakhin
<rouslan+webkit at chromium.org>'s request for review:
Bug 108370: Some spellcheck tests require asynchronous spellcheck
https://bugs.webkit.org/show_bug.cgi?id=108370

Attachment 191329: Patch
https://bugs.webkit.org/attachment.cgi?id=191329&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191329&action=review


It would be better to split this into 2 patches: 1 patch that refactors sync
and async to share code and 1 patch to change the tests.  It's hard to read the
diff due to code moving around.

> Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:232
> +    bindMethod("setContinuousSpellCheckingEnabled",
&TestRunner::setContinuousSpellCheckingEnabled);

We should implement this in Internals.{h,cpp,idl} so all the ports can share
this.  Maybe we should do a patch to move setAsynchronousSpellCheckingEnabled
to Internals first.