[webkit-reviews] review granted: [Bug 109125] [chromium] Clean up WebWidget / WebLayerTreeView interactions : [Attachment 191315] rebased
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 4 15:35:28 PST 2013
Adrienne Walker <enne at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 109125: [chromium] Clean up WebWidget / WebLayerTreeView interactions
https://bugs.webkit.org/show_bug.cgi?id=109125
Attachment 191315: rebased
https://bugs.webkit.org/attachment.cgi?id=191315&action=review
------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191315&action=review
R=me.
> Source/WebKit/chromium/src/WebViewImpl.h:156
> + virtual WebInputHandler* createInputHandler() OVERRIDE;
> + virtual void applyScrollAndScale(const WebSize&, float);
Just a drive-by comment, but what's with the inconsistent use of OVERRIDE in
this block if these are all WebWidget methods?
More information about the webkit-reviews
mailing list