[webkit-reviews] review granted: [Bug 111312] Web Inspector: allow retrieval of composited layers in a given DOM subtree : [Attachment 191223] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 111312: Web Inspector: allow retrieval of composited layers in a given DOM
subtree
https://bugs.webkit.org/show_bug.cgi?id=111312

Attachment 191223: Patch
https://bugs.webkit.org/attachment.cgi?id=191223&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191223&action=review


> Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:136
> +	   gatherLayersUsingRenderLayerHierarchy(errorString,
renderer->enclosingLayer(), layers);

renderer->enclosingLayer() should just be
toRenderLayerModelObject(renderer)->layer()

> Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:179
> +    int id = domAgent->boundNodeId(node);
> +    if (!id)
> +	   id = domAgent->pushNodeToFrontend(errorString,
domAgent->boundNodeId(node->document()), node);

Don't use 'id' in code; it will conflict with Objective-C's reserved word if
this is ever turned into Obj-C++.