[webkit-reviews] review granted: [Bug 110854] Unused Structure property tables waste 14MB on Membuster. : [Attachment 191298] Patch II: The Repatchening

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 110854: Unused Structure property tables waste 14MB on Membuster.
https://bugs.webkit.org/show_bug.cgi?id=110854

Attachment 191298: Patch II: The Repatchening
https://bugs.webkit.org/attachment.cgi?id=191298&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191298&action=review


r=me

> Source/JavaScriptCore/runtime/Structure.h:457
> +    // Should be accessed through propertyTable().

Would be nice to elaborate in this comment that what makes
m_propertyTableUnsafe unsafe is that, during GC, it may be set to 0 by another
thread.

> Source/JavaScriptCore/runtime/WriteBarrier.h:102
> +	   // Copy cell to a local to avoid multiple-read issues. See
<http://webkit.org/b/110854>)

Missing a parenthesis here.