[webkit-reviews] review granted: [Bug 111245] Add API to allow WK2 clients to query the list of installed plug-ins. : [Attachment 191289] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 111245: Add API to allow WK2 clients to query the list of installed
plug-ins.
https://bugs.webkit.org/show_bug.cgi?id=111245

Attachment 191289: Patch
https://bugs.webkit.org/attachment.cgi?id=191289&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191289&action=review


> Source/WebKit2/UIProcess/API/C/WKContext.h:56
> +    WKContextPlugInInformationAvailableCallback			  
plugInInformationAvailable;

Maybe plugInInformationBecameAvailable or plugInInformationLoaded?

> Source/WebKit2/UIProcess/Plugins/PluginInfoStore.h:41
> +class PluginInfoStoreClient {

It would be nice to put this in a separate file. PluginInfoStore.h has data and
includes a client is unlikely to ever care about, yet it currently has to
include the whole thing to implement PluginInfoStoreClient interface.

Not such a big deal, since there is only one client that's already huge.