[webkit-reviews] review denied: [Bug 76796] [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes : [Attachment 190329] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Brian Holt
<brian.holt at samsung.com>'s request for review:
Bug 76796: [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes
https://bugs.webkit.org/show_bug.cgi?id=76796

Attachment 190329: Patch
https://bugs.webkit.org/attachment.cgi?id=190329&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190329&action=review


can you add a layout test for this (r- for the no layout test)

> Source/WebCore/html/HTMLSelectElement.cpp:1126
>	   const String& keyIdentifier =
static_cast<KeyboardEvent*>(event)->keyIdentifier();

can you move this keyIdentifier call up before your snippet of code, then that
line won't have to be duplicated