[webkit-reviews] review denied: [Bug 111314] Web Inspector: Track CSS error location information. : [Attachment 191243] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Sergey Ryazanov
<serya at chromium.org>'s request for review:
Bug 111314: Web Inspector: Track CSS error location information.
https://bugs.webkit.org/show_bug.cgi?id=111314

Attachment 191243: Patch
https://bugs.webkit.org/attachment.cgi?id=191243&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191243&action=review


> Source/WebCore/ChangeLog:5
> +	   Grammar has been refactored.

You should explain what is going to happen, link to the meta bug that lists all
the steps that you are going to make.

> Source/WebCore/css/CSSParser.cpp:9308
> +}

As I suggested, you should start with landing the plumbing.

> Source/WebCore/css/CSSParser.cpp:10469
> +		   getCurrentToken<SrcCharacterType>(&yylval->string);

This change seems to be unrelated to what you are doing.