[webkit-reviews] review granted: [Bug 111328] [chromium] pass all focus handling methods through the WebTestDelegate : [Attachment 191240] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 07:46:47 PST 2013


Nico Weber <thakis at chromium.org> has granted jochen at chromium.org's request for
review:
Bug 111328: [chromium] pass all focus handling methods through the
WebTestDelegate
https://bugs.webkit.org/show_bug.cgi?id=111328

Attachment 191240: Patch
https://bugs.webkit.org/attachment.cgi?id=191240&action=review

------- Additional Comments from Nico Weber <thakis at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191240&action=review


> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:427
> +	   Base::didFocus();

nit: the other methods in this class tend to call the Base:: version first


More information about the webkit-reviews mailing list