[webkit-reviews] review denied: [Bug 111308] [v8] add isolate parameter to heap statistics calls : [Attachment 191219] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 06:43:43 PST 2013


jochen at chromium.org has denied Dan Carney <dcarney at google.com>'s request for
review:
Bug 111308: [v8] add isolate parameter to heap statistics calls
https://bugs.webkit.org/show_bug.cgi?id=111308

Attachment 191219: Patch
https://bugs.webkit.org/attachment.cgi?id=191219&action=review

------- Additional Comments from jochen at chromium.org
View in context: https://bugs.webkit.org/attachment.cgi?id=191219&action=review


> Source/WebCore/inspector/InspectorMemoryAgent.cpp:207
> +    ScriptGCEvent::getHeapSize(v8::Isolate::GetCurrent(), info);

everything from here on is WebCore and can't depend directly on v8::


More information about the webkit-reviews mailing list