[webkit-reviews] review denied: [Bug 110692] [GTK] Move basic dependency installation to a script : [Attachment 190065] v3

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Tomas Popela
<tpopela at redhat.com>'s request for review:
Bug 110692: [GTK] Move basic dependency installation to a script
https://bugs.webkit.org/show_bug.cgi?id=110692

Attachment 190065: v3
https://bugs.webkit.org/attachment.cgi?id=190065&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190065&action=review


Small issues with the packages lists, but otherwise looks good to me, I'll r-
since I think you're not a committer

> Tools/ChangeLog:1
> +2013-02-25  Martin Robinson	<mrobinson at igalia.com>, Tomas Popela
<tpopela at redhat.com>

Small nit: I think the usual way is to add an 'and' instead of a comma, also
the syntax of ChangeLogs asks for two spaces between the name and the email
address

> Tools/gtk/install-dependencies:77
> +	   ruby \

The lists of packages have a trailing \

> Tools/gtk/install-dependencies:89
> +	   xvfb \

Here.

> Tools/gtk/install-dependencies:138
> +	   perl-version \

Here.

> Tools/gtk/install-dependencies:149
> +	   xorg-x11-server-Xvfb \

Here.