[webkit-reviews] review granted: [Bug 110875] [V8] Add a "context type" parameter to GetTemplate and ConfigureV8SomethingTemplate functions : [Attachment 191186] Patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 4 02:56:34 PST 2013
Kentaro Hara <haraken at chromium.org> has granted Marja Hölttä
<marja at chromium.org>'s request for review:
Bug 110875: [V8] Add a "context type" parameter to GetTemplate and
ConfigureV8SomethingTemplate functions
https://bugs.webkit.org/show_bug.cgi?id=110875
Attachment 191186: Patch.
https://bugs.webkit.org/attachment.cgi?id=191186&action=review
------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191186&action=review
LGTM. Thanks for the patch!
> Source/WebCore/ChangeLog:9
> + The parameter will later be used for generating specialized V8
> + bindings for the 3 different world types (main world, isolated
> + work, worker).
> +
We normally write the description between the "Reviewed By" line and the
"Test:" line. Please do it from your next patch.
More information about the webkit-reviews
mailing list