[webkit-reviews] review granted: [Bug 111292] Web Inspector: touchmove not emulated inside iframe : [Attachment 191170] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 111292: Web Inspector: touchmove not emulated inside iframe
https://bugs.webkit.org/show_bug.cgi?id=111292

Attachment 191170: Patch
https://bugs.webkit.org/attachment.cgi?id=191170&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191170&action=review


> Source/WebCore/page/EventHandler.cpp:1631
> +    // FIXME: this should be moved elsewhere to also be able to dispatch
touchcancel events.

Isn't this comment obsolete?

> Source/WebCore/page/EventHandler.cpp:1632
> +    bool defaultPrevented =
dispatchSyntheticTouchEventIfEnabled(mouseEvent);

if (dispatchSyntheticTouchEventIfEnabled(mouseEvent))
    return true;