[webkit-reviews] review granted: [Bug 109828] [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch : [Attachment 189280] patch v5

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 109828: [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process
crash and relaunch
https://bugs.webkit.org/show_bug.cgi?id=109828

Attachment 189280: patch v5
https://bugs.webkit.org/attachment.cgi?id=189280&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189280&action=review


r=me as signed off my benjamin

>> Tools/TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:41

>> +static const char* dataToPass;
> 
> For a common test, I would say this should be test local.
> For EFL tests, you do as you wish I guess.

Mikhail can you have a look to see if you could make this change? People will
look at current tests when writing new ones