[webkit-reviews] review denied: [Bug 110291] Move WebCore feature defines to the WebCore directory : [Attachment 191065] remove change from chromium/config.h

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Laszlo Gombos
<laszlo.gombos at webkit.org>'s request for review:
Bug 110291: Move WebCore feature defines to the WebCore directory
https://bugs.webkit.org/show_bug.cgi?id=110291

Attachment 191065: remove change from chromium/config.h
https://bugs.webkit.org/attachment.cgi?id=191065&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191065&action=review


> Source/WTF/wtf/FeatureDefines.h:-332
> -#if !defined(ENABLE_CANVAS_PATH)
> -#define ENABLE_CANVAS_PATH 1
> -#endif

What about these where the defaults are non-zero?

> Source/WTF/wtf/FeatureDefines.h:-344
> -#if !defined(ENABLE_CONTEXT_MENUS)
> -#define ENABLE_CONTEXT_MENUS 1
> -#endif

For example, this one isn't in features.gypi.

This seems very fragile!