[webkit-reviews] review granted: [Bug 111223] [V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell : [Attachment 191039] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 2 23:18:20 PST 2013


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 111223: [V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=111223

Attachment 191039: Patch
https://bugs.webkit.org/attachment.cgi?id=191039&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191039&action=review


> Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:435
> +	   return v8Undefined();

Should we pass the isolate to v8Undefined ?


More information about the webkit-reviews mailing list