[webkit-reviews] review granted: [Bug 110171] StringHasher functions require alignment that call sites do not all guarantee : [Attachment 191122] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 110171: StringHasher functions require alignment that call sites do not all
guarantee
https://bugs.webkit.org/show_bug.cgi?id=110171

Attachment 191122: Patch
https://bugs.webkit.org/attachment.cgi?id=191122&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Thanks for doing all the tests!

My only comment is it would be useful to have a comments for each group of
test.
E.g.:
    // addCharactersAssumingAligned with zero characters should produce an
emptyStringHash.
    // addCharactersAssumingAligned with \0.
    // addCharactersAssumingAligned with 5 characters at once.
etc.

Otherwise it takes some reading to find what is tested in each paragraph.