[webkit-reviews] review granted: [Bug 111248] constructTreeFromCompactHTMLToken should call clearExternalCharacters : [Attachment 191102] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 111248: constructTreeFromCompactHTMLToken should call
clearExternalCharacters
https://bugs.webkit.org/show_bug.cgi?id=111248

Attachment 191102: Patch
https://bugs.webkit.org/attachment.cgi?id=191102&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191102&action=review


> Source/WebCore/ChangeLog:10
> +	   I don't know how to write a test for this.  It's possible
characters()
> +	   is never accessed from HTMLStackItem::token(), but it's better to be

> +	   safe than sorry here.

Yeah, there isn't any behavior change from this patch, but it's worth doing
anyway.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:573
> +    token->clearExternalCharacters(); // The compact token could be
destroyed any time after this method returns.

Yeah, we do the same thing in HTMLDocumentParser::constructTreeFromHTMLToken