[webkit-reviews] review granted: [Bug 110298] [EFL][QT][WK2] Turn on ApplyDeviceScaleFactorInCompositor always. : [Attachment 190679] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 110298: [EFL][QT][WK2] Turn on ApplyDeviceScaleFactorInCompositor always.
https://bugs.webkit.org/show_bug.cgi?id=110298

Attachment 190679: Patch
https://bugs.webkit.org/attachment.cgi?id=190679&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190679&action=review


> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:457
>  {
>      page()->setIntrinsicDeviceScaleFactor(scale);
> +    setSize(m_size);
>  }

It is not obvious that this actually changes the size.

I would definitely add a comment. // Update internal viewport size after
device-scale change.